This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix: allow the nest field missing in the multi-index query #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thincal Thanks for your fix! But your PR failed our GitHub Action build. Could you check its log or do And please add unit test and integration test as per our instruction here: https://github.com/opendistro-for-elasticsearch/sql/blob/master/docs/developing.rst#tips-for-testing. Thanks! |
thincal
force-pushed
the
fix-support-nested-field-missing
branch
2 times, most recently
from
0f4b69f to
221047d
Compare
thincal
force-pushed
the
fix-support-nested-field-missing
branch
from
221047d to
20b0f53
Compare
|
lets reopen this PR with some tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #348 *
Description of changes:
let
checkMappingCompatibilityapplied to the nested fields